Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component tests #227

Merged
merged 8 commits into from
Mar 20, 2021
Merged

Add component tests #227

merged 8 commits into from
Mar 20, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Mar 3, 2021

Begins the process of adding tests for individual components.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #227 (b684ece) into master (d2e8a06) will increase coverage by 5.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   28.57%   33.58%   +5.01%     
==========================================
  Files          33       33              
  Lines         658      658              
  Branches      133      133              
==========================================
+ Hits          188      221      +33     
+ Misses        426      394      -32     
+ Partials       44       43       -1     
Impacted Files Coverage Δ
components/AppInfoFooter.js 100.00% <ø> (+100.00%) ⬆️
components/BrowserListItem.js 100.00% <ø> (+100.00%) ⬆️
components/ButtonListItem.js 100.00% <ø> (+100.00%) ⬆️
components/ServerListItem.js 100.00% <ø> (+100.00%) ⬆️
components/SwitchListItem.js 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e8a06...b684ece. Read the comment docs.

@thornbill thornbill force-pushed the component-tests branch 2 times, most recently from 3d044fb to 07d0cfe Compare March 3, 2021 14:39
@github-actions github-actions bot added the merge conflict Conflicts prevent merging label Mar 4, 2021
@thornbill thornbill removed the merge conflict Conflicts prevent merging label Mar 5, 2021
@github-actions github-actions bot added the merge conflict Conflicts prevent merging label Mar 10, 2021
@github-actions github-actions bot removed the merge conflict Conflicts prevent merging label Mar 11, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.7% 8.7% Duplication

@thornbill thornbill marked this pull request as ready for review March 19, 2021 15:52
@thornbill thornbill merged commit 1d0631b into jellyfin:master Mar 20, 2021
@thornbill thornbill deleted the component-tests branch March 20, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants