Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (November edition) #623

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Compile / Target Android API 30
  • Update Gradle to 6.7
  • Update Android Build Tools to 4.1
  • Initialize Timber before Koin (in case an injected class uses logging in constructor)
  • Update Koin to 2.2
    • Enabled logger again
    • Fixed a bunch of classes using KoinComponent, which is discouraged
    • Added the fragment extension
    • Switched to androidx version for viewmodel
  • Updated all other dependencies

Issues

@nielsvanvelzen
Copy link
Member Author

I meant to add the link to the Koin 2.2 blog post but forgot to do so:
https://medium.com/koin-developers/whats-next-with-koin-2-2-3-0-releases-6c5464ae5e3d

@thornbill
Copy link
Member

I get the following error when I try to run with these changes in Android Studio.

Unable to determine application id: com.android.tools.idea.run.ApkProvisionException: No outputs for the main artifact of variant: debug

@nielsvanvelzen
Copy link
Member Author

Is your Android studio installation updated to the latest version and did you sync the gradle configuration?

@nielsvanvelzen
Copy link
Member Author

I just experienced the same issue when I switched from this branch to another branch (based on current master) and a Gradle Sync fixed it.

@thornbill
Copy link
Member

Weird I had tried a Gradle sync, but restarting Android Studio fixed it for me.

@thornbill thornbill merged commit 4bdcdaa into jellyfin:master Nov 16, 2020
@nielsvanvelzen nielsvanvelzen deleted the deps-2020-11 branch November 18, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants