Fix unlabeled image buttons for accessibility #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Oct 3, 2020
app/src/main/java/org/jellyfin/androidtv/ui/livetv/LiveTvGuideActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/AudioNowPlayingActivity.java
Outdated
Show resolved
Hide resolved
...main/java/org/jellyfin/androidtv/ui/playback/overlay/CustomPlaybackTransportControlGlue.java
Outdated
Show resolved
Hide resolved
|
I think I just made a mistake by fetching and rebasing the upstream commits. Should I git rebase and drop the upstream commits? |
|
Yes, please do |
nielsvanvelzen
requested changes
Oct 7, 2020
app/src/main/java/org/jellyfin/androidtv/ui/livetv/LiveTvGuideActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/AudioNowPlayingActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/AudioNowPlayingActivity.java
Outdated
Show resolved
Hide resolved
|
Hi @jemlule, are you still interested in finishing this pull request? |
|
Yes I am! Sorry for being inactive. |
|
Issues
======
- Added 3
See the complete overview on Codacy |
| @@ -353,6 +353,9 @@ private void prepareBackgroundManager() { | |||
| getActivity().getWindowManager().getDefaultDisplay().getMetrics(mMetrics); | |||
| } | |||
|
|
|||
| protected ImageButton mSortButton; | |||
There was a problem hiding this comment.
| @@ -353,6 +353,9 @@ private void prepareBackgroundManager() { | |||
| getActivity().getWindowManager().getDefaultDisplay().getMetrics(mMetrics); | |||
| } | |||
|
|
|||
| protected ImageButton mSortButton; | |||
| protected ImageButton mSearchButton; | |||
| protected ImageButton mSettingsButton; | |||
There was a problem hiding this comment.
| @@ -353,6 +353,9 @@ private void prepareBackgroundManager() { | |||
| getActivity().getWindowManager().getDefaultDisplay().getMetrics(mMetrics); | |||
| } | |||
|
|
|||
| protected ImageButton mSortButton; | |||
| protected ImageButton mSearchButton; | |||
There was a problem hiding this comment.
nielsvanvelzen
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
setContentDescriptionto the buttons unlabeled: those to sort the movies/musics, those before the play/resume (put to favorite, mark the media viewed…) and those in the playback overlay.Issues
Fixes #418