Add Koin for dependency injection #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've started reviewing but it will take some time since there's a lot of changes. |
nielsvanvelzen
requested changes
Sep 15, 2020
app/src/main/java/org/jellyfin/androidtv/integration/ChannelManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/presentation/ThemeManager.kt
Outdated
Show resolved
Hide resolved
|
My general approach was to use |
|
I don't see a problem with that, although I prefer using inject via properties everywhere (but I think you did that already in the Kotlin code) |
Co-authored-by: Niels van Velzen <[email protected]>
|
Issues
======
+ Solved 1
- Added 1
Clones removed
==============
+ app/src/main/java/org/jellyfin/androidtv/ui/playback/CustomPlaybackOverlayFragment.java -1
+ app/src/main/java/org/jellyfin/androidtv/ui/livetv/LiveTvGuideActivity.java -1
See the complete overview on Codacy |
| @@ -56,11 +59,11 @@ class NextUpActivity : FragmentActivity() { | |||
| } | |||
|
|
|||
| private suspend fun loadItemData(id: String) = withContext(Dispatchers.IO) { | |||
| val item = TvApp.getApplication().apiClient.getItem(id) ?: return@withContext null | |||
| val item = apiClient.getItem(id) ?: return@withContext null | |||
There was a problem hiding this comment.
nielsvanvelzen
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds Koin for dependency injection and migrates some global app state to using it instead of referencing TvApp.
Issues
N/A