Fix VLC audio passthrough #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
requested changes
Jul 22, 2020
app/src/main/java/org/jellyfin/androidtv/playback/VideoManager.java
Outdated
Show resolved
Hide resolved
thornbill
requested changes
Jul 25, 2020
thornbill
approved these changes
Aug 21, 2020
nielsvanvelzen
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some issues with VLC audio passthrough on the nvidia shield which caused Atmos to not work correctly. Believe this was due to an overall slight misconfiguration of VLC audio passthrough.
Changes
This slightly changes the way audio is configured for libvlc to be more in-line with the way https://github.com/videolan/vlc-android works.
Issues
#281