Add support for vertical grids #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grade A poetry, love the juxtaposition of horizontal and vertical in the instanceof repetitio. |
|
Unfortunately the grid presenters don't implement an interface for their shared functionality :( |
nielsvanvelzen
force-pushed
the
vertical-grids
branch
from
f04afa5 to
ca9b4e3
Compare
thornbill
requested changes
May 20, 2020
app/src/main/java/org/jellyfin/androidtv/browsing/StdGridFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/browsing/StdGridFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/preferences/UserPreferences.kt
Outdated
Show resolved
Hide resolved
nielsvanvelzen
commented
May 20, 2020
app/src/main/java/org/jellyfin/androidtv/preferences/UserPreferences.kt
Outdated
Show resolved
Hide resolved
thornbill
requested changes
May 21, 2020
thornbill
approved these changes
May 22, 2020
|
Looks good now! Just a minor conflict that needs fixed! |
nielsvanvelzen
force-pushed
the
vertical-grids
branch
from
733e281 to
b552d3a
Compare
|
Complexity increasing per file
==============================
- app/src/main/java/org/jellyfin/androidtv/ui/GridFragment.java 9
Clones removed
==============
+ app/src/main/java/org/jellyfin/androidtv/browsing/StdGridFragment.java -1
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more poetry and spaghetti to the grid code to allow vertical grids! A user preference is added and will default to the new vertical view.
Changes
Issues