Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Timber for logging #471

Merged
merged 2 commits into from
May 5, 2020
Merged

Use Timber for logging #471

merged 2 commits into from
May 5, 2020

Conversation

thornbill
Copy link
Member

Changes
Adds Timber as a logging library

Issues
N/A

Blocked by #468

@thornbill thornbill added the blocked Needs another PR first label May 2, 2020
@codeclimate
Copy link

codeclimate bot commented May 4, 2020

Code Climate has analyzed commit 8657973 and detected 17 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 14

Note: there is 1 critical issue.

View more on Code Climate.

@thornbill thornbill removed the blocked Needs another PR first label May 4, 2020
@thornbill thornbill marked this pull request as ready for review May 4, 2020 21:03
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nielsvanvelzen nielsvanvelzen merged commit 3c5ad27 into jellyfin:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants