Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playback activity crashing #465

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix playback activity crashing #465

merged 1 commit into from
Apr 29, 2020

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Cleaned the cleaned code
  • When creating the view of the fragment it will now not attach to the root (as it should be)
    • This caused a new issue
  • Moved the code that created the videomanager and pushed it to the playbackcontroller
    • It's now created as soon as the view in the fragment is created (lifecycle)
    • This also cleans the activity a bit (which is nice because it will be easier to switch to less activities in the future)

Issues

  • none!

🤡

@codeclimate
Copy link

codeclimate bot commented Apr 29, 2020

Code Climate has analyzed commit 361beff and detected 0 issues on this pull request.

View more on Code Climate.

@nielsvanvelzen
Copy link
Member Author

This fixes an issue caused by #458

@thornbill thornbill merged commit 94be57b into jellyfin:master Apr 29, 2020
@nielsvanvelzen nielsvanvelzen deleted the ijustwantedtowatchsomethingbuthadtospendtimefixingthisbecauseibrokeit branch May 1, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @thornbill