Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple external video playback from internal playback code #4438

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nielsvanvelzen
Copy link
Member

This is an older branch and I'm not entirely sure what I didn't finish 🙈. Needs testing (@BotBlake, @TimGels). I need this for a different change I'm working on, that is needed for yet another change I want to work on 🗿.

Changes

  • Rewrite ExternalPlayerActivity
    • Detached from other playback code (except for the queue)
    • Cleaner code, removed a bunch of cruft
    • always directplays the file

Testing needed for:

  • Do all subtitles still work (including external?)
  • Does reporting still work (e.g. is the item marked watched when returning to the app)
    • Does reporting also not work when the external player fails to play?
  • Does the queue advancing still work? (auto play next item on finish)

Issues

@nielsvanvelzen nielsvanvelzen added enhancement New feature or request needs-testing labels Feb 4, 2025
@nielsvanvelzen nielsvanvelzen added this to the v0.19.0 milestone Feb 4, 2025
@TimGels
Copy link
Member

TimGels commented Feb 4, 2025

@nielsvanvelzen which external player needs to be tested? I have a few that I can test like vlc and mx player.

@nielsvanvelzen
Copy link
Member Author

Just in general to see if the Jellyfin app still behaves like it should, you can test that with whatever external player you want.

@nielsvanvelzen nielsvanvelzen changed the title Decouple ExternalPlayerActivity from playback code Decouple external video playback from internal playback code Feb 4, 2025
@theguymadmax
Copy link

theguymadmax commented Feb 4, 2025

Resume from x position - starts playback at the start for both Just Player and VLC
Just Player - will save the resume position
VLC - doesn't save the resume position

External subs don't display as an option for Just Player (use to)
External subs don't display as an option for VLC (never did)

@BotBlake
Copy link
Member

BotBlake commented Feb 5, 2025

From playing arround a bit, I didnt find direct Playback Issues.
(Tested on CCwGTV HD using MXPlayer)

All issues I found:

  • autoplay of the next Episode does not work.

  • VLC support is back? - Using VLC as external player not working on stable but on this branch

  • On Some files AC3 Audio doesnt play (MXPlayer) (also an issue on stable)

  • Client Ignores External Player Setting when using Playlist (also an issue on stable)

  • Shuffle all episodes completely breaks Seeking (MxPlayer) (also an issue on stable)

  • I forgot what I wanted to write because I fell asleep (a me issue)

  • Integrated Subs dont show on MXPlayer (also an issue on stable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants