Dismiss playback actions popups on fragment detach #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
approved these changes
Jan 3, 2025
nielsvanvelzen
added
bug
nielsvanvelzen
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Dismiss playback actions popups on fragment detach * Update CONTRIBUTORS.md (cherry picked from commit d91d873)
nielsvanvelzen
removed
the
backportable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Dismiss popups from playback actions (ex: closed captions, audio track, etc...) when the video player fragment is detached.
An open popup could hold an invalid reference to a
videoPlayerAdapterwhen the app was exited and re-opened.Issues
Fixes #4163
Other comments
I noticed that the actions have slightly different code styles for handling popups. I tried to not move stuff around too much, but I would not mind streamlining stuff a bit :)