Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video restarting immediately when baking subtitles #4122

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

nielsvanvelzen
Copy link
Member

In some cases there is no preferred subtitle track client side, but the server does have one. When this track needs baking (SSA/ASS) there was a tiny bug in the client where it would restart playback because it thought it had to switch subtitle tracks.

Changes

  • Fix video restarting immediately when baking subtitles
  • Remove log spam from MediaCodecCapabilitiesTest

Issues

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Oct 30, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Oct 30, 2024
@nielsvanvelzen nielsvanvelzen merged commit b3beb8a into jellyfin:master Oct 30, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the no-multi-start branch October 30, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants