Add preference for default zoom mode #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Sep 28, 2024
app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt
Outdated
Show resolved
Hide resolved
nielsvanvelzen
requested changes
Oct 1, 2024
app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt
Outdated
Show resolved
Hide resolved
...c/main/java/org/jellyfin/androidtv/ui/preference/screen/PlaybackAdvancedPreferencesScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/ZoomAction.kt
Outdated
Show resolved
Hide resolved
Update string for zoom mode preference to aspect ratio. Update variable name for playerZoomMode in UserPreferences.kt
# Conflicts: # app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt # app/src/main/java/org/jellyfin/androidtv/ui/preference/screen/PlaybackAdvancedPreferencesScreen.kt
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java
Fixed
Show fixed
Hide fixed
Removed unused line of code.
JagerSprinkles
changed the title
|
Thanks for the pull request! I've pushed some final changes to fix some formatting, rename an enum member, changed the preference order. I also fixed a missing setter for |
nielsvanvelzen
approved these changes
Oct 12, 2024
|
Thanks for the small fixes at the end! I'm happy to contribute to the project and look forward to submitting more PRs in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change will add a setting under advanced playback preferences to set the default zoom mode. This mode will be used every time a video is started as the setting is not saved if adjusted during playback.
Issues
Possibly fixes #1981