Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify video player preference #3663

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Remove preferred video player preference
  • Remove preferred Live TV player preference
  • Add "use external player" preference (used for all video related playback)
  • Remove "choose player" menu

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Jun 11, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jun 11, 2024
@neopc10
Copy link

neopc10 commented Jun 11, 2024

Can we have something like "long press play button in episode details to use external player?"

@nielsvanvelzen
Copy link
Member Author

No, you either have external player enabled for everything or you don't.

@nielsvanvelzen nielsvanvelzen merged commit 071bdac into jellyfin:master Jun 11, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the simplify-player-pref branch June 15, 2024 11:41
@gulabbisht
Copy link

@nielsvanvelzen, is there any way to choose which external player will be used, like vlc?

@nielsvanvelzen
Copy link
Member Author

The external player functionality uses the video player configured as default app in the OS.

@kingp0dd
Copy link

kingp0dd commented Aug 3, 2024

Can we have something like "long press play button in episode details to use external player?"

I can see a use case for this too. I use exoplayer as default for the resume functionality, but there are videos that do not play with exoplayer, which i have to open with Kodi. So what i do is go to settings to choose "Ask every time" as default video player and then revert the setting again after watching the unplayable video

@yemrearslan
Copy link

this is an issue for me because the default player doesn't have subtitle offset option. i can choose vlc as default player but it doesn't show the subtitles downloaded via opensubitles plug-in. i think there must be an option to use libvlc player

@nielsvanvelzen
Copy link
Member Author

Please stop commenting on pull requests, especially when they're unrelated to your "issue". This pull request did not remove LibVLC.

@sheharyarn
Copy link

Was there a reason for removing "choose player" option? It allowed customizing the playback experience, and I really liked it.

@miberecz

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants