Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully migrate ItemListFragment to use SDK #3574

Merged
merged 1 commit into from
May 16, 2024
Merged

Fully migrate ItemListFragment to use SDK #3574

merged 1 commit into from
May 16, 2024

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented May 14, 2024 •
edited
Loading

Changes

  • Refactor ItemListFragment to use SDK types (BaseItemDto)
  • Add ItemListFragmentHelper for API calls in ItemListFragment
  • Remove unused addItems function in ItemListView

Issues

@nielsvanvelzen nielsvanvelzen added sdk-migration To fix this we need to migrate some code to the new SDK refactor Improvements to code realiability, readability and quality labels May 15, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone May 15, 2024
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review May 15, 2024 16:55
@nielsvanvelzen nielsvanvelzen requested a review from crobibero May 16, 2024 18:40
@nielsvanvelzen nielsvanvelzen merged commit f772258 into jellyfin:master May 16, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the item-list-fragment-sdk branch May 16, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero