Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audio mute features #322

Merged

Conversation

nielsvanvelzen
Copy link
Member

Applications shouldn't change the device audio except when it's caused by user interaction. The app does not contain any UI elements to do this but we still have code to mute/unmute the device.

This PR removes the setAudioMuted method from the TvApp class and all references to it.

There is at least one issue in Tracepot that will be solved with this PR.
Maybe fix #309

Copy link
Contributor

@AndreasGB AndreasGB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid deletion, looks good :D

@nielsvanvelzen nielsvanvelzen merged commit b451c3f into jellyfin:master Feb 9, 2020
@nielsvanvelzen nielsvanvelzen deleted the leave-my-audio-alone branch February 10, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jellyfin mutes Android TV
2 participants