Fix system screensaver starting during video playback #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -38,17 +47,20 @@ | |||
| timer?.cancel() | |||
|
|
|||
| // Hide when interacted with allowed cancelation or when disabled | |||
| if (_visible.value && (canCancel || !enabled || activityPaused)) { | |||
| if (_visible.value && (canCancel || !inAppEnabled || activityPaused)) { | |||
Check warning
Code scanning / detekt
Complex conditions should be simplified and extracted into well-named methods if necessary. Warning
crobibero
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLAG_KEEP_SCREEN_ONwas never set if not using the new in-app screensaver. This caused the system screensaver to start during video playback... whoops.From my initial testing this does however crash the video player once the (system-)screensaver is closed and the app needs to resume.
Will need to do some more testing and potentially fix that (separate PR)see #3207.Changes
Issues
Fixes #3193