Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GridButtonPresenter focus on old Android platforms #3133

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix GridButtonPresenter focus on old Android platforms #3133

merged 1 commit into from
Oct 20, 2023

Conversation

nielsvanvelzen
Copy link
Member

Two issues:

  1. Old Android versions need isFocusableInTouchMode for some stupid reason
  2. The focus was actually sent to the ComposeView so we had to block it

Changes

  • Fix GridButtons not working on Android ~7ish and below

Issues

Fixes #3118

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Oct 20, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Oct 20, 2023
@nielsvanvelzen nielsvanvelzen merged commit 37112e5 into jellyfin:master Oct 20, 2023
@nielsvanvelzen nielsvanvelzen deleted the nvv-grid-button-focus branch October 20, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.16.0
2 participants
@nielsvanvelzen @crobibero