Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab background images no larger than the screen #3020

Merged

Conversation

DoggoOfSpeed
Copy link
Contributor

Changes
Fix the app grabbing 4k background images even when the screen is just 1080p.

As a side-effect that also saves a lot of cache space :)

@nielsvanvelzen
Copy link
Member

I'm not sure about this one. Yes it reduces the image size on smaller screens which leads to smaller cache but at the same time it will now make the server resize all images and cache them there which makes the (first) requests slower.

@DoggoOfSpeed
Copy link
Contributor Author

Well for me personally that still makes some sense.

Sure, it takes time to process the images, but in turn that means the images require less bandwith and are quicker to download.

The same can kinda be applied to storage space as the server, in all likelyhood, is much less storage limited whereas many tvs and set-top boxes don't even have 8gb.

@nielsvanvelzen
Copy link
Member

Right that's true, should be fine to change this then.

@nielsvanvelzen
Copy link
Member

Looking a bit further we should use fillWidth instead of maxWidth and also add fillHeight.

@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Sep 19, 2023
@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Sep 19, 2023
@nielsvanvelzen nielsvanvelzen merged commit f7f51a6 into jellyfin:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants