Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PersonType into a proper enum #288

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Refactor PersonType into a proper enum #288

merged 1 commit into from
Feb 4, 2020

Conversation

AndreasGB
Copy link
Contributor

@nielsvanvelzen nielsvanvelzen added the blocked Needs another PR first label Feb 4, 2020
@nielsvanvelzen nielsvanvelzen removed the blocked Needs another PR first label Feb 4, 2020
nielsvanvelzen
nielsvanvelzen approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed we used this enum a bit more.. Checked in the code but nope this is everything!

@nielsvanvelzen nielsvanvelzen merged commit d26db9c into jellyfin:master Feb 4, 2020
@AndreasGB AndreasGB deleted the PersonTypeRefactor branch February 4, 2020 10:45
@thornbill thornbill mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasGB @nielsvanvelzen