Add volume state to playback rewrite #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Fixed
Show fixed
Hide fixed
nielsvanvelzen
force-pushed
the
playback-volume
branch
from
60828b8 to
802f3d9
Compare
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/data/eventhandling/SocketHandler.kt
Fixed
Show fixed
Hide fixed
nielsvanvelzen
force-pushed
the
playback-volume
branch
from
802f3d9 to
b6f3531
Compare
nielsvanvelzen
added
enhancement
playback/jellyfin/src/main/kotlin/playsession/PlaySessionSocketService.kt
Fixed
Show fixed
Hide fixed
nielsvanvelzen
force-pushed
the
playback-volume
branch
from
b6f3531 to
ba6a19b
Compare
crobibero
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add volume state and manipulation to the playback code. It is also exposed to media sessions, play sessions and remote control. This means you can change the volume of your TV from jellyfin-web or the mobile app. Useful when playing music!
Issues
yes #1057