Fix navigating back from an actor page should keep focus on the actors row #2788
Conversation
update master
… should keep focus on the actors row
fedesenmartin
changed the title
|
It looks like the same issue also exists in the AudioNowPlayingFragment. Perhaps you can fix that file in this same pull request. |
app/src/main/java/org/jellyfin/androidtv/ui/itemdetail/FullDetailsFragment.java
Outdated
Show resolved
Hide resolved
| @@ -59,7 +59,11 @@ class MyDetailsOverviewRowPresenter( | |||
| } | |||
|
|
|||
| binding.fdButtonRow.removeAllViews() | |||
| for (button in row.actions) binding.fdButtonRow.addView(button) | |||
| for (button in row.actions) { | |||
| if (button.parent != null) { | |||
There was a problem hiding this comment.
This check makes the buttons never show at all.
edit: to properly fix the crash that exists without this check we should update the "MyDetailsOverViewRow" to only contain data and not views. So the TextUnderButon is instantiated in the presenter.
There was a problem hiding this comment.
removed from "MyDetailsOverViewRow" all views; but without this check if (button.parent != null) I cant get rid off this crash -> java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
There was a problem hiding this comment.
You're storing the views in the presenter instead of the viewholder right now. That means views are still re-used. You need to make sure to never re-use the views and scope them to the viewholder.
refactor to fulldetailsfragment and indentation use getChildFragmentManager on AudioNowPlaying fragment instead of supportfragment manager
|
Hey @fedesenmartin, are you still working on this PR/planning to finish it? |
|
I am not actively working on the fix. I have an idea on how to solve it, but it requires rewriting the entire view. I will continue it when I have a moment, unless there is a significant change in the code. I will leave it as a draft if that's okay with you, in case someone wants to continue it. Does that sound okay to you? @nielsvanvelzen |
|
Closing this PR as stale. |
Changes
FullDetailsFragment.javaandAudioNowPlayingFragment.javaFullDetailsFragment.javaIssues:
Fixes #2713