Add HomeFragmentRow for live tv buttons #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It looks good, had some trouble setting up a live tv source so I could actually test it but I got it working.
From what I can see it will change the behavior in comparison to the web client but that shouldn't be that big of a deal as long as the row can be configured in the client.
Another options might be to add the livetv buttons to the footer or add navigation from the library screen.
For now everything looks good, had a few suggestions for the Kotlin code but you don't really need to change it (although the one for null safety makes the code look better imo)
app/src/main/java/org/jellyfin/androidtv/ui/home/HomeFragmentLiveTVRow.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/home/HomeFragmentLiveTVRow.kt
Outdated
Show resolved
Hide resolved
nielsvanvelzen
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores some missing buttons for Live TV that were removed by the home section changes. I moved those buttons and the guide button to a separate row to reflect the web ui.