Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use getQuantityString() for time units #2553

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Always use getQuantityString() for time units #2553

merged 1 commit into from
Feb 28, 2023

Conversation

nielsvanvelzen
Copy link
Member

I introduced plurals in #2539 and they work great in Weblate. This allows different locales to use their own way of displaying time units.

Changes

  • Rewrite TimeUtils.formatSeconds to use plurals
  • Remove old strings for seconds,minute(s) and hour(s)
    • Replaced usages with getQuantityString()

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Feb 28, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Feb 28, 2023
@nielsvanvelzen nielsvanvelzen merged commit 9f80ec6 into jellyfin:master Feb 28, 2023
@nielsvanvelzen nielsvanvelzen deleted the time-plurals branch February 28, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero