Add MediaSessionPlugin to playback rewrite #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Android Lint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
nielsvanvelzen
force-pushed
the
playback-mediasession
branch
from
ace5834 to
3a55ee3
Compare
crobibero
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're slowly getting a usable playback module! This PR adds MediaSession support. A media session is what enables stuff like the media notification, google assistant integration, controlling media from other apps / tv remote and more. It's quite a big deal.
For some reason, the default Android TV launcher doesn't load the images from URL (mobile Android does) so we need to fetch the bitmaps and put them in the data as well. We should also proxy the image requests via our own ImageProvider at some point to allow authenticated image requests. But this should probably be initiated from the BaseItemDtoUserQueueEntry builder.
Changes
Issues
Part of #1057