Fix switching to encoded subtitles causing the video player to hang. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .switchSubtitleStream() function calls the stop & play functions which would then call the switch function and this ended up looping. Adding an additional check if the to be switched to stream isn't the current already prevents this.
dkanada
reviewed
Dec 2, 2019
|
I tried that at first but I still got some issues so I used the current solution. I'll have another look at it later this week to see if I can fix it outside of the |
…title index didn't change when starting playback.
dkanada
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .switchSubtitleStream() function calls the stop & play functions which will then call the switch function and this ends up looping.
Adding an additional check if the stream we want to switch to isn't the currently used stream prevents this.