Allow using the modifier on SVG and math elements (#235)

jelhan · Feb 12, 2024 · 9ce17f6 · 9ce17f6
1 parent 26bf164
commit 9ce17f6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/ember-style-modifier/src/modifiers/style.ts b/ember-style-modifier/src/modifiers/style.ts
@@ -44,7 +44,7 @@ function compileStyles(
 }
 
 export interface StyleModifierSignature {
-  Element: HTMLElement;
+  Element: Element & ElementCSSInlineStyle;
   Args: {
     Positional: CSSStyles[];
     Named: CSSStyles;
@@ -54,7 +54,10 @@ export interface StyleModifierSignature {
 export default class StyleModifier extends Modifier<StyleModifierSignature> {
   existingStyles: Set<string> = new Set();
 
-  setStyles(element: HTMLElement, newStyles: [string, string][]) {
+  setStyles(
+    element: StyleModifierSignature['Element'],
+    newStyles: [string, string][],
+  ) {
     const { existingStyles } = this;
     const rulesToRemove: Set<string> = new Set(existingStyles);
 
@@ -92,7 +95,11 @@ export default class StyleModifier extends Modifier<StyleModifierSignature> {
     rulesToRemove.forEach((rule) => element.style.removeProperty(rule));
   }
 
-  modify(element: HTMLElement, positional: [CSSStyles] | [], named: CSSStyles) {
+  modify(
+    element: StyleModifierSignature['Element'],
+    positional: [CSSStyles] | [],
+    named: CSSStyles,
+  ) {
     this.setStyles(element, compileStyles(positional, named));
   }
 }
diff --git a/test-app/tests/integration/modifiers/style-test.ts b/test-app/tests/integration/modifiers/style-test.ts
@@ -60,6 +60,12 @@ module('Integration | Modifiers | style', function (hooks) {
     assert.dom('p').hasStyle({ fontSize: '6px' });
   });
 
+  test('it supports usage on SVG elements', async function (assert) {
+    await render(hbs`<svg {{style display="none"}}></svg>`);
+
+    assert.dom('svg').hasStyle({ display: 'none' });
+  });
+
   {
     interface Context extends TestContext {
       // eslint-disable-next-line @typescript-eslint/ban-types