Skip to content

Conversation

@ashmaroli
Copy link
Member

Summary

Load latest Font Awesome Free webfonts via remote CDN.

Interface changes

(w.r.t. current master)

  • Config keys under minima:social_links are now:
    • icon - Font Awesome icon id. e.g. icon: github corresponds to FA icon fa-github.
    • url - Full social profile URL.
    • title - link-title rendered onMouseOver icon.
  • Manage via a single include_file: _includes/social.html. The following are removed:
    • _includes/social-icons/*.svg 🔥
    • _includes/social-item.html 🔥
    • _includes/svg_symbol.html 🔥
    • assets/minima-social-icons.liquid 🔥

N.B: icon for RSS is now inlined into HTML markup.

Motivation

  • Reduce end-user development complexity associated with existing flow (on master).
  • Remove Maintainer overhead on managing pull requests and issue tickets regarding social-icons.

@ashmaroli
Copy link
Member Author

Preview: https://deploy-preview-839--jekyll-minima.netlify.app/
TODO: Comment-out minima:social_links in config file before merging

Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit acb0519 into jekyll:master Feb 9, 2025
3 checks passed
jekyllbot added a commit that referenced this pull request Feb 9, 2025
@ashmaroli ashmaroli deleted the font-awesome-social-icons branch February 9, 2025 10:37
janthmueller added a commit to janthmueller/Stoic-Quote-Of-The-Day that referenced this pull request Feb 11, 2025
janthmueller added a commit to janthmueller/janthmueller that referenced this pull request Feb 11, 2025
uranuno added a commit to uranuno/PagesTest that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants