Skip to content

Fix deprecation warnings from Dart Sass #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
+11 −11
Merged

Fix deprecation warnings from Dart Sass #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89714e3
Fix warnings about `slash-div` deprecation
ashmaroli Sep 5, 2024
52f758d
Fix warnings about `nested-rule` deprecation
ashmaroli Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions _sass/minima/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ h1, h2, h3, h4, h5, h6,
p, blockquote, pre,
ul, ol, dl, figure,
%vertical-rhythm {
margin-bottom: $spacing-unit / 2;
margin-bottom: $spacing-unit * 0.5;
}


Expand Down Expand Up @@ -131,7 +131,7 @@ a {
blockquote {
color: $grey-color;
border-left: 4px solid $grey-color-light;
padding-left: $spacing-unit / 2;
padding-left: $spacing-unit * 0.5;
@include relative-font-size(1.125);
letter-spacing: -1px;
font-style: italic;
Expand Down Expand Up @@ -186,8 +186,8 @@ pre {
@include media-query($on-laptop) {
max-width: -webkit-calc(#{$content-width} - (#{$spacing-unit}));
max-width: calc(#{$content-width} - (#{$spacing-unit}));
padding-right: $spacing-unit / 2;
padding-left: $spacing-unit / 2;
padding-right: $spacing-unit * 0.5;
padding-left: $spacing-unit * 0.5;
}
}

Expand Down Expand Up @@ -241,7 +241,7 @@ table {
}
}
th, td {
padding: ($spacing-unit / 3) ($spacing-unit / 2);
padding: ($spacing-unit * 0.3333333333) ($spacing-unit * 0.5);
}
th {
background-color: lighten($grey-color-light, 3%);
Expand Down
12 changes: 6 additions & 6 deletions _sass/minima/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
@include media-query($on-palm) {
position: absolute;
top: 9px;
right: $spacing-unit / 2;
right: $spacing-unit * 0.5;
background-color: $background-color;
border: 1px solid $grey-color-light;
border-radius: 5px;
Expand Down Expand Up @@ -90,12 +90,12 @@

.page-link {
display: block;
margin-left: 20px;
padding: 5px 10px;

&:not(:last-child) {
margin-right: 0;
}
margin-left: 20px;
}
}
}
Expand All @@ -112,7 +112,7 @@

.footer-heading {
@include relative-font-size(1.125);
margin-bottom: $spacing-unit / 2;
margin-bottom: $spacing-unit * 0.5;
}

.contact-list,
Expand All @@ -124,14 +124,14 @@
.footer-col-wrapper {
@include relative-font-size(0.9375);
color: $grey-color;
margin-left: -$spacing-unit / 2;
margin-left: -$spacing-unit * 0.5;
@extend %clearfix;
}

.footer-col {
float: left;
margin-bottom: $spacing-unit / 2;
padding-left: $spacing-unit / 2;
margin-bottom: $spacing-unit * 0.5;
padding-left: $spacing-unit * 0.5;
}

.footer-col-1 {
Expand Down