Skip to content

Conversation

@ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Dec 19, 2022

Summary

  • Respect feed.path setting in config file.
    • Render feed url via absolute_url to mirror {% feed_tag %} output.
  • Always inject rss icon symbol in spritesheet irrespective of config file entry.
    • Extract symbol template into an include file.
    • Rename spritesheet template to have .liquid extension for improved readability in supported text-editors / IDE.
  • Remove rel="me" for feed link in footer.

Context

Fixes #692
Fixes #697

@ashmaroli ashmaroli requested a review from mattr- December 19, 2022 15:34
@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 2f032a4 into jekyll:master Dec 22, 2022
jekyllbot added a commit that referenced this pull request Dec 22, 2022
@ashmaroli ashmaroli deleted the fix-feed-icon-url branch December 22, 2022 16:35
@jekyll jekyll locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feed.xml name hardcoded RSS icon depends on "rss" social_link, but "Subscribe" link does not

3 participants