Skip to content

Update config #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DirtyF merged 2 commits into from
Apr 10, 2018
Merged

Update config #228

DirtyF merged 2 commits into from
Apr 10, 2018

Conversation

@DirtyF
Copy link
Member

@DirtyF DirtyF commented Apr 10, 2018 •
edited
Loading

Link to feed is broken on https://jekyll.github.io/minima/ I guess it's because we have to tell in the config that the theme uses the jekyll-feed plugin.

Also listed jekyll-seo-tag to be consistent

  • remove useless directives as we already have defaults defined for markdown engine and excluded files.

fix #227

@DirtyF DirtyF requested a review from a team April 10, 2018 08:56
@ashmaroli
Copy link
Member

ashmaroli commented Apr 10, 2018

I think you can delete the exclude: array as well since Jekyll has got a more wholesome array by default..
Though I recommend that you move the deletions out of this PR and into a dedicated branch..

@ashmaroli
Copy link
Member

ashmaroli commented Apr 10, 2018

I wonder how GitHub Pages built the site successfully without loading the plugins..
Liquid would've aborted with an Unknown Tag {% seo %} (or {% feed_meta %}) exception..

@DirtyF DirtyF changed the title List plugins used by minima Update config Apr 10, 2018
@DirtyF DirtyF added the fix label Apr 10, 2018
@parkr
Copy link
Member

parkr commented Apr 10, 2018

I wonder how GitHub Pages built the site successfully
GitHub Pages defaults to jekyll-theme-primer if you don't specify a theme, and it depends on jekyll-seo-tag, so it's automatically required by Jekyll now. 😸

@DirtyF DirtyF merged commit 5cb9009 into master Apr 10, 2018
@DirtyF DirtyF deleted the config branch April 10, 2018 13:16
@jekyllbot jekyllbot mentioned this pull request Apr 10, 2018
Merged
@jekyll jekyll locked and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@parkr parkr parkr approved these changes

Assignees

No one assigned

Labels

fix frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RSS Feed is broken

5 participants

@DirtyF @ashmaroli @parkr @jekyllbot