Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<meta> http-equiv attribute is added in the page <head> where I use jemoji #41

Closed
milanaryal opened this issue May 20, 2016 · 4 comments
Closed

<meta> http-equiv attribute is added in the page <head> where I use jemoji #41

milanaryal opened this issue May 20, 2016 · 4 comments
Labels
frozen-due-to-age

Comments

@milanaryal
Copy link

milanaryal commented May 20, 2016 •
edited
Loading

If I use jemoji in the page, <meta http-equiv="content-type" content="text/html; charset=UTF-8"> is added in <head> section

capture-1

There's no issue, if jemoji is disabled

capture-2
@milanaryal milanaryal changed the title <meta> http-equiv attribute is added in a page <head> where I use jemoji <meta> http-equiv attribute is added in the page <head> where I use jemoji May 20, 2016
@parkr
Copy link
Member

parkr commented May 20, 2016

As discussed in benbalter/benbalter.github.com#383 (please cross-reference when you can!), this is due to Nokogiri or HTML Pipeline, specifically:

jemoji/lib/jemoji.rb

Line 15 in b376b82

parsed_doc = Nokogiri::HTML::Document.parse(doc.output)

@benbalter
Copy link
Contributor

Based on

jemoji/lib/jemoji.rb

Line 12 in b376b82

return unless doc.output =~ HTML::Pipeline::EmojiFilter.emoji_pattern
, this should only affect documents with emoji then, correct?

@benbalter benbalter mentioned this issue May 29, 2016
Closed
@rajsite
Copy link

rajsite commented Jun 19, 2016 •
edited
Loading

This showing up in the page also prevents me from using jemoji on amp-html pages:

image

Error message: The attribute 'content' in tag 'meta http-equiv=Content-Type' is set to the invalid value 'text/html; charset=UTF-8'.

For the curious, I believe the associated amp validation rule is disallowed property inside attribute in tag and another issue preventing use of jemoji with amp-html pages is discussed here: #42

@parkr parkr mentioned this issue Jul 19, 2016
Closed
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@ghost ghost mentioned this issue Sep 15, 2016
Closed
@jekyllbot jekyllbot removed the stale label Oct 26, 2016
@benbalter benbalter mentioned this issue Mar 1, 2017
Closed
@orangy orangy mentioned this issue Jan 7, 2018
Open
spike1292 added a commit to spike1292/spike1292.github.io that referenced this issue Apr 14, 2018
@spike1292
remove jemoji & jekyll-mentions
5e4e9b4 
jekyll/jemoji#41
jekyll/jekyll-mentions#37
@jekyll jekyll locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@parkr @benbalter @rajsite @jekyllbot @milanaryal