-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid theme folder: _sass
when using Github Pages with remote_theme
#7630
Comments
Further reading... It seems that the warning message was introduced in #5195 to offer useful debug information when needed but, in this case... it is throwing false positives when using benbalter/jekyll-remote-theme plugin. |
@cetinajero So that means this message does not reflect an error? |
@moritzschaefer No. It's just a warning that the theme you're using doesn't have |
@DirtyF |
@ashmaroli Than you, I agree; the warning is confusing. It implies there is something that needs correcting. I've just encountered this after upgrading to jekyll 3.8 (via github-pages 198), for a theme that does not have a Why is this a warning? What consequence is there for not including a |
Exactly @moritzschaefer, isn't something to worry about too much.
@ashmaroli, in my case there is a My theory is that the warning is showing before the jekyll-remote-theme plugin has fetch the contents of the remote theme and, therefore... the I have added a logger to the def realpath_for(folder)
Jekyll.logger.warn "realpath_for:", folder
File.realpath(Jekyll.sanitized_path(root, folder.to_s))
rescue Errno::ENOENT, Errno::EACCES, Errno::ELOOP
Jekyll.logger.warn "Invalid theme folder:", folder
nil
end And this is the output that I get:
Please note that the
At least... that's my theory haha... Will I be right @ashmaroli? |
Not much really, you can use plain CSS and all be good, but... it's better to write all your style using SASS partials @ellemenno. |
…tion Note that local builds now throw invalid warnings as noted in: jekyll/jekyll#7630
I consider myself an experienced user and I wouldn't have caught the color of the message meaning "warning". I'm not sure that's the most accessible way to convey the importance, or lack thereof. What I do see is invalid theme folder
I think we're at a time and place that Jekyll shouldn't force Sass on development. I'm using PostCSS for partials among other optimizations. I'm not suggesting dropping support, just not make assumption it's the only way to process styling files. |
@cetinajero Looks like you're right indeed. Good job with the investigation.
@miklb I agree with you as well. The logged message isn't entirely accurate, (and based on comments in this thread, the message can also be misleading in a certain situation.. 🤷♂️ ) |
Thanks @ashmaroli! I really don't know how to solve it nor why the |
@cetinajero We won't be able to "fix" Regarding the dubious log message from Jekyll, we can adapt from another method of the same class: Lines 19 to 23 in b3770fd
|
Hmmm... I was thinking something more complex like checking if the entire root directory was empty... then skip the warning and wait for the second check, but... adapting the message seems fairly easy and doable. Even with the new message... the warning can be misleading in certain situations and it is present in Like this two logs on the same class: Lines 11 to 12 in b3770fd
|
That won't be necessary once
Perhaps not in the same PR.. The warning was placed there as an aid for theme developers that their gem doesn't include a certain directory at the gem's root. The "complex" solution would be to log a warning / debug msg, only if the theme wishes to publish sass partials but hasn't been bundled into the gem. |
When I said "get rid of the annoying message" I was only suggesting lower its level to
Even with this solution... the Jekyll theme I'm developing (jekyll-theme-marketing) has sass partials that are bundled into the gem but the Jekyll's It seems that rephrasing the msg is the best option, I'll send you the PR in a moment. |
This change is proposed since the log output it is not actionable for the end-user. Fixes jekyll#7630
This change is proposed since the log output it is not actionable for the end-user. Fixes jekyll#7630
I'm also affected by this bug. |
My Environment
circleci/ruby:2.4.1
jekyll
github-pages
Jekyll-remote-theme
Expected Behaviour
A normal build without the warning:
Invalid theme folder: _sass
.Current Behavior
Hi, we have a Jekyll theme build for our own Jekyll sites on a separate repo accessed thru jekyll-remote-theme and all have been working just fine until yesterday that we upgraded from
v3.7.4
tov3.8.5
(based on the Github pages-gem v198 release).When using Jekyll
v3.8.x
, there is a warning showing us:Invalid theme folder: _sass
, this warning goes away if Jekyll is downgraded tov3.7.4
.The warning isn't affecting us because the
/_sass
folder does exists on the Jekyll theme repo and all SCSS files are precompiled just fine. We think that this warning is telling us that the/_sass
folder doesn't exist on the main repo but that it's expected and it shouldn't produce any warning.What do you suggest?
The text was updated successfully, but these errors were encountered: