-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't mention in code block. #7
Comments
This can be fixed once Jekyll 2.0.0 :ships: as we should be able to modify the HTML (rather than the markdown input) and could properly know if something is inside a code block via the tree. Until then, using /cc @parkr in case the use case is helpful for callback planning. |
using |
I can extend this report further now that Jekyll 2 is on GHP. Mentions should also not occur in |
This should be fixed in HTML Pipeline: jch/html-pipeline |
Tracking upstream. |
Is this fixed in the version running on the |
@davidcelis No clue. gjtorikian/html-pipeline#163 was closed and I can't find any further discussion about fixing it. I just hit the same issue I reported in #7 (comment), but this time with an |
is finally fixed
This breaks code highlighting for me right now. Had to disable the plugin to make highlighting work. This was breaking for me. {% highlight bash %}
$ echo hello > /dev/null
{% endhighlight %} The problem is that the plugin is HTML escaping everything, including |
- At least until jekyll/jekyll-mentions#7 is fixed - Was processing SCSS `@import` references
and wait for jekyll/jekyll-mentions#7 to be fixed
I found that jekyll-mentions turns such
@import
in code block to github users' link. It is annoying, right?I think we need to add some roles to ignore some phrases like
@import
. I like mentions, but I don't want to destory my code block.The text was updated successfully, but these errors were encountered: