Skip to content

chore: use Dir to list source files #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2020
Merged

chore: use Dir to list source files #309

merged 1 commit into from
May 11, 2020

Conversation

@DirtyF
Copy link
Member

@DirtyF DirtyF commented Apr 27, 2020 •
edited
Loading

@DirtyF DirtyF requested a review from a team April 27, 2020 20:18
@ashmaroli
Copy link
Member

ashmaroli commented Apr 28, 2020

Is your motivation behind this to follow a convention or to just bundle the necessary files in the gem?
If it is the latter case, then IMHO the gem contents ought to roughly be:

  lib/**/*
- script/**/*
- spec/**/*
- .gitignore
- .rspec
- .rubocop.yml
- .travis.yml
- appveyor.yml
- Gemfile
  History.markdown
- Rakefile
  README.md

@DirtyF
Copy link
Member Author

DirtyF commented Apr 28, 2020 •
edited
Loading

@ashmaroli looks like it would be easier to only add lib and Markdown files :)

@ashmaroli
Copy link
Member

ashmaroli commented Apr 28, 2020

Yep. :select instead of :reject.. 😉

@DirtyF
Copy link
Member Author

DirtyF commented May 9, 2020

@ashmaroli found an even simpler way to list files with Dir thanks to @piotrmurach

@DirtyF DirtyF changed the title chore: reject tests folders from gem's files chore: use Dir to list source files May 9, 2020
@ashmaroli
Copy link
Member

ashmaroli commented May 11, 2020

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 54976f6 into master May 11, 2020
@jekyllbot jekyllbot added the fix label May 11, 2020
@jekyllbot jekyllbot deleted the chore/gemspec branch May 11, 2020 16:09
jekyllbot added a commit that referenced this pull request May 11, 2020
@jekyllbot
Update history to reflect merge of #309 [ci skip]
eee0245
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Merged
@jekyll jekyll locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees

No one assigned

Labels

fix frozen-due-to-age internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DirtyF @ashmaroli @jekyllbot