-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for categories frontmatter #153
Conversation
I had to add some tests, which required creating a second fixture site. Could you tell me if this is sane, or if maybe there is a better way to do this?
I had to create a second fixture site because the feed is limited to 10 items, and the feed already contained 10 items 😂 |
spec/jekyll-feed_spec.rb
Outdated
post = feed.items.first | ||
expect(post.categories[0].term).to eql('1') | ||
expect(post.categories[1].term).to eql('2') | ||
expect(post.categories[2].term).to eql('3') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I should name the categories first
, second
, third
?
205167b
to
e822845
Compare
thanks @pathawks! |
Please, someone, merge it 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test is failing
thanks for pushing this forward all |
Do we have any news with this? Would be nice being able to support the |
Oh man, can you put this into README ? |
@pathawks I pushed changes to how this was tested. Do you have any issues with the current diff..? |
As @SGOrava mentioned, until this is merged and released, can you at least put it in the README that "categories" frontmatter is not supported? Not knowing that just cost me two hours. |
This comment has been minimized.
This comment has been minimized.
@jekyllbot: merge +minor |
wonderful |
Replaces #130
Fixes #129