Freeze all Ruby string literals #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
reviewed
Feb 10, 2020
There was a problem hiding this comment.
Required Ruby version should be 2.3+ then no?
https://github.com/jekyll/classifier-reborn/blob/master/classifier-reborn.gemspec#L9
Technically, older Ruby versions will consider the pragma to be just a regular comment. Also, just to be sure, I'll open a separate PR that builds on CI with older Rubies.. |
|
Let's just bump the gemspec. Everything older than 2.4 is EOL anyways. |
parkr
approved these changes
Feb 10, 2020
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Feb 10, 2020
muffinista
pushed a commit
to bandzoogle/classifier-reborn
that referenced
this pull request
Jul 29, 2020
Merge pull request 190
muffinista
pushed a commit
to bandzoogle/classifier-reborn
that referenced
this pull request
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce their allocation on modern Rubies