Skip to content

Commit

Permalink
Removed test_files from gemspec
Browse files Browse the repository at this point in the history
I was just looking through the code installed for teaspoon, and I noticed that the /spec/dummy directory is huge. It turns out that rubygems is packaging up not only /spec/dummy, but also all the tempfiles and logfiles there *at the time of packaging*.

The latest consensus is that test_files shouldn't be packaged with a gem anyway (see rubygems/bundler#3207) because they're never used, so rather than filtering out /spec/dummy/log and /spec/dummy/tmp I've prevented rubygems from packing test files at all.
  • Loading branch information
iainbeeston committed Jul 2, 2015
1 parent 9796f89 commit 59d51fd
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion teaspoon.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ Gem::Specification.new do |s|
s.license = "MIT"

s.files = Dir["{app,lib,bin}/**/*"] + ["MIT.LICENSE", "README.md", "CHANGELOG.md"]
s.test_files = `git ls-files -- {spec}/*`.split("\n")
s.executables = ["teaspoon"]

s.add_dependency "railties", [">= 3.2.5", "< 5"]
Expand Down

0 comments on commit 59d51fd

Please sign in to comment.