Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Black header titles Dark Mode on mobile #38

Closed
CypherpunkSamurai opened this issue May 18, 2021 · 2 comments
Closed

[BUG] Black header titles Dark Mode on mobile #38

CypherpunkSamurai opened this issue May 18, 2021 · 2 comments
Assignees
@jeffreytse
Labels
bug Something isn't working verified This issue was already verified

Comments

@CypherpunkSamurai
Copy link

Hi, I tried this theme and the menu titles are unreadable in dark mode.

Also i would suggest please add another dark mode without #000000. It would suit the eyes better at night.
@jeffreytse jeffreytse self-assigned this May 18, 2021
@jeffreytse jeffreytse added bug Something isn't working verified This issue was already verified labels May 18, 2021
jeffreytse added a commit that referenced this issue May 18, 2021
@jeffreytse
fix: text color of header on mobile (#38)
9eda84b 
When the dark mode is on and on the mobile, the header text color
is also dark, we should change it to light color for the contrast.
@jeffreytse
Copy link
Owner

Hi @CypherpunkSamurai

Thanks for the reporting. Now this issue has been addressed and fixed, please update your code to the latest version.

Thanks and regards

@CypherpunkSamurai
Copy link
Author

Thanks. That was a crazy fast commit. Thank you for dedicating your time to this issue :)

shahbaz22 pushed a commit to shahbaz22/resonance-site that referenced this issue Nov 17, 2024
@jeffreytse
fix: text color of header on mobile (jeffreytse#38)
d808c5d 
When the dark mode is on and on the mobile, the header text color
is also dark, we should change it to light color for the contrast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreytse jeffreytse

Labels
bug Something isn't working verified This issue was already verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffreytse @CypherpunkSamurai