Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore node_modules packege.json for workspace #52

Merged
merged 1 commit into from
May 28, 2020
Merged

ignore node_modules packege.json for workspace #52

merged 1 commit into from
May 28, 2020

Conversation

tanmen
Copy link
Contributor

@tanmen tanmen commented May 28, 2020 •
edited
Loading

When I use workspaces, the package.json in node_modules is also targeted.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 100.0% when pulling fcf9023 on tanmen:workspace-node-modules into 23f8a5c on jeffijoe:master.

@jeffijoe jeffijoe merged commit 6bb8175 into jeffijoe:master May 28, 2020
@jeffijoe
Copy link
Owner

Thanks!

@tanmen
Copy link
Contributor Author

tanmen commented May 29, 2020

Thank you!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanmen @coveralls @jeffijoe