Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monorepos including projects with unpublished npm package names 🤣 #117

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Fix monorepos including projects with unpublished npm package names 🤣 #117

merged 7 commits into from
Jul 17, 2024

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jul 16, 2024 •
edited
Loading

Fixes #116.

And, becuase I'm absolutely terrible at small, focused PRs:

  • Update transpilation config
  • Update ESLint config
  • Declare a PM for Corepack, etc
  • Fix ESLint vscode support
  • Use the correct URI encoding function

@lishaduck
chore: transpile to node16
96b120c 
Engines is set to Node 16, so you needn't transpile async/await, etc, away.
@lishaduck
fix: declare a pm
f92859a 
Makes PNPM stop yelling when linking locally.
@lishaduck
fix: use correct url encoder
cff9fe4 
I noticed this, I think it's right.
@lishaduck
fix: unpublished packages
84fac79
@lishaduck
chore: remove old comments
cea0645
@lishaduck
fix: vscode
b06f1fe
@lishaduck
fix: eslint disable
3451dd2
@lishaduck lishaduck changed the title Fix monorepos with unpublished package names 🤣 Fix monorepos including projects with unpublished npm package names 🤣 Jul 16, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 100.0%. remained the same
when pulling 3451dd2 on lishaduck:fix-monorepos
into 0aa02b3 on jeffijoe:master.

@lishaduck lishaduck mentioned this pull request Jul 17, 2024
Merged
@jeffijoe jeffijoe merged commit 7aecb96 into jeffijoe:master Jul 17, 2024
5 checks passed
@lishaduck lishaduck deleted the fix-monorepos branch July 17, 2024 15:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffijoe jeffijoe jeffijoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes from root on PNPM monorepo
3 participants
@lishaduck @coveralls @jeffijoe