Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop matches-selector dependency #8

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Drop matches-selector dependency #8

merged 2 commits into from
Mar 10, 2021

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Sep 8, 2020

Element.matches is supported everywhere. If you want to support IE, the code can be slightly changed to use .msMatchesSelector if available (but IE is dead)

This improves ES Modules support because the dependency is not an ES Module

@fregante
Copy link
Contributor Author

fregante commented Mar 8, 2021

@jefersondaniel ping if you have time

@jefersondaniel jefersondaniel merged commit 03114ec into jefersondaniel:master Mar 10, 2021
@jefersondaniel
Copy link
Owner

Thanks!

@fregante fregante deleted the patch-1 branch March 10, 2021 01:21
@fregante
Copy link
Contributor Author

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants