fix: when local dns error occurs try every dns #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
util/wait_internet.go
Outdated
Comment on lines
30
to
31
| if isDNSErr(err) || errTimes > 0 { | ||
| dns := BackupDNS[errTimes%len(BackupDNS)] |
There was a problem hiding this comment.
Suggested change
| if isDNSErr(err) || errTimes > 0 { | |
| dns := BackupDNS[errTimes%len(BackupDNS)] | |
| if isDNSErr(err) && len(BackupDNS) > 0 { | |
| dns := BackupDNS[0] | |
| BackupDNS = BackupDNS[1:] |
这样用完一个删一个是不是更好些？
There was a problem hiding this comment.
有没有可能删除最后，也不通。也许在下一次循环就通了
There was a problem hiding this comment.
有没有可能删除最后，也不通。也许在下一次循环就通了
// Rotate the backup DNS for reuse.
dns := BackupDNS[0]
BackupDNS = append(BackupDNS[1:], dns)不删除了，轮换吧。
There was a problem hiding this comment.
那就没什么需要改的了，把 errTimes 这个命名改的更贴近用例就行了。因为并不是所有错误都会 ++，retryTimes 怎么样？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when local dns error occurs try every dns
Motivation
Additional Notes
improve #1057