Skip to content

Conversation

@Rolv-Apneseth
Copy link
Collaborator

Hey @jeertmans, this is just (hopefully) a quick one with some dependency updates, in an attempt to help close some of those automated PRs, so we can deal with the issues in one place.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.18%. Comparing base (85567fa) to head (b0d08ac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parsers/markdown.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   31.25%   31.18%   -0.08%     
==========================================
  Files          19       19              
  Lines         819      821       +2     
==========================================
  Hits          256      256              
- Misses        563      565       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #180 will not alter performance

Comparing Rolv-Apneseth:update_deps (b0d08ac) with main (85567fa)

🎉 Hooray! codspeed-rust just leveled up to 4.0.5!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched

@jeertmans jeertmans added ci Continuous Integration related (GitHub actions, precommit, …) dependencies Pull requests that update a dependency file labels Oct 31, 2025
@jeertmans jeertmans changed the title chore: update deps chore(ci): update deps Oct 31, 2025
@Rolv-Apneseth
Copy link
Collaborator Author

The failing docs build is because anstyle-parse and anstyle-query don't have versions available on crates.io which include the doc_auto_cfg -> doc_cfg changes present in the anstyle repo. Might have to wait on those to get updated, then for clap to pick those up, before we can merge this.

Also, the large min rust version bump can be brought down to just 1.83.0 if we keep typst-syntax at 0.13.1 instead of 0.14.

@Rolv-Apneseth
Copy link
Collaborator Author

Oh, and I haven't updated annotate-snippets as that's a bigger job

@Rolv-Apneseth
Copy link
Collaborator Author

Might need a if: ${{ github.repository_owner == 'jeertmans' }} or similar for the publish action.

@jeertmans
Copy link
Owner

Hi @Rolv-Apneseth, thanks for this PR! I think I have addressed all the remaining bugs, see my commits.

@Rolv-Apneseth
Copy link
Collaborator Author

Hi @Rolv-Apneseth, thanks for this PR! I think I have addressed all the remaining bugs, see my commits.

No problem and thanks for the fixes.

Just the date for the nightly toolchain on that rustdoc action - think that should be different. It's still running 1.93.0-nightly.

@Rolv-Apneseth
Copy link
Collaborator Author

It was pointed out to me here that if the CI is trying to emulate docs.rs then it should probably have --no-deps, avoiding the issue mentioned above.

@jeertmans
Copy link
Owner

It was pointed out to me here that if the CI is trying to emulate docs.rs then it should probably have --no-deps, avoiding the issue mentioned above.

Makes sense, thanks!

@jeertmans
Copy link
Owner

Looks good to me, thank you for your help @Rolv-Apneseth!

@jeertmans jeertmans merged commit 74406d5 into jeertmans:main Oct 31, 2025
25 of 28 checks passed
@jeertmans
Copy link
Owner

Oops, I merged this a bit too quickly: we should document the MSRV bump because this is considered a soft breaking change.

@Rolv-Apneseth
Copy link
Collaborator Author

Under unreleased in the changelog?

@jeertmans
Copy link
Owner

Under unreleased in the changelog?

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration related (GitHub actions, precommit, …) dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants