-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return entire module as promise #108
Conversation
Awesome! |
Oh, sorry, just noticed I forgot to remove line 565 (thought I'd done that before committing). |
No problem. Removed :) |
Aie. It doesn't seem to work, at least without wasm. > require('libsodium-wrappers') { add: [Function],
base64_variants:
{ ORIGINAL: 1,
ORIGINAL_NO_PADDING: 3,
URLSAFE: 5,
URLSAFE_NO_PADDING: 7 },
compare: [Function],
from_base64: [Function],
from_hex: [Function],
from_string: [Function: a],
increment: [Function],
is_zero: [Function] } Not a promise :( |
And with wasm, the promise is rejected
|
Don't bother if this looks hard to fix, we can stick to the previous system with the promise returned along with other properties. |
00e8ed0 probably fixes the second thing :) |
Now without wasm we get all the symbols. But directly, instead of the promise. |
Oops, sorry about the |
As discussed in #105.