Only adjust terminal size when the output writer is stdout#375
Merged
jedib0t merged 4 commits intojedib0t:mainfrom Nov 6, 2025
Merged
Only adjust terminal size when the output writer is stdout#375jedib0t merged 4 commits intojedib0t:mainfrom
jedib0t merged 4 commits intojedib0t:mainfrom
Conversation
Pull Request Test Coverage Report for Build 19111272497Details
💛 - Coveralls |
jedib0t
reviewed
Oct 28, 2025
|
Contributor
Author
|
@jedib0t can you take another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic adjusting the rendering based on terminal size assumes the output is stdout. This is only makes sense when the output is stdout.
Proposed Changes
p.watchTerminalSize()so it's only called when p.outputWriter is set to os.Stdout