Skip to content

OSC 8 hiperlink support#364

Merged
jedib0t merged 1 commit intojedib0t:mainfrom
scribe-security:fix/OSC_8_hiperlink
Mar 27, 2025
Merged

OSC 8 hiperlink support#364
jedib0t merged 1 commit intojedib0t:mainfrom
scribe-security:fix/OSC_8_hiperlink

Conversation

@houdini91
Copy link
Copy Markdown
Contributor

Fix handling of OSC 8 hyperlinks (e.g., \x1b]8;;url\x07label\x1b]8;;\x07) in escSeqParser.Consume

Add support for BEL (\x07)-terminated OSC sequences, which are used in hyperlinks (instead of the typical ESC )

Ensures that escape sequences are correctly parsed and excluded from visible text width calculations

Signed-off-by: houdini91 <mdstrauss91@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14018453830

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.872%

Changes Missing Coverage Covered Lines Changed/Added Lines %
text/escape_seq_parser.go 4 9 44.44%
Totals Coverage Status
Change from base Build 13608767539: -0.1%
Covered Lines: 3891
Relevant Lines: 3896

💛 - Coveralls

@jedib0t jedib0t merged commit 18e8a01 into jedib0t:main Mar 27, 2025
4 checks passed
@jedib0t
Copy link
Copy Markdown
Owner

jedib0t commented Jul 28, 2025

Hey. I apologize for not cutting a tag after merging this. I've just cut a tag: https://github.com/jedib0t/go-pretty/releases/tag/v6.6.8

I guess better late than never. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants