Skip to content
This repository has been archived by the owner on Dec 25, 2024. It is now read-only.

Crash with ncurses 6.1 with the "wide" feature #151

Closed
ngg opened this issue Apr 17, 2018 · 0 comments · Fixed by #153
Closed

Crash with ncurses 6.1 with the "wide" feature #151

ngg opened this issue Apr 17, 2018 · 0 comments · Fixed by #153

Comments

@ngg
Copy link
Contributor

ngg commented Apr 17, 2018

In this case the executable is linked to libncursesw.so.6 and to libtinfo.so.6
This did not cause a problem before ncurses 6.1, but now it crashes.
libtinfo.so.6 is coming from pkg_config which is looking for "ncurses" instead of "ncursesw".
Other projects have this same issue as well: vifm/vifm#325 (comment)

I think the proper fix would be to check "ncursesw", "ncursesw5" (and possible "ncursesw6") with pkg_config if the "wide" feature is enabled (and not on macosx) instead of the current ones. In src/ll.rs it should be unnecessary to specify the shared library again.
ngg added a commit to ngg/ncurses-rs that referenced this issue Apr 22, 2018
@ngg
Use pkg-config for all linked libraries.
01f61f7 
Fixes jeaye#151.
ngg added a commit to ngg/ncurses-rs that referenced this issue Apr 25, 2018
@ngg
Use pkg-config for all linked libraries.
a1fdd1a 
Fixes crashes when mixing wide and non-wide linker dependencies.

For example if both the "wide" and the "panel" features are enabled,
libncursesw.so and libpanel.so were linked which can not work together.

Another example is on Gentoo Linux where ncurses is split into
libncurses.so and libtinfo.so, previously libtinfo.so and libncursesw.so
were linked together if the "wide" feature was set.

Also fix the recognition of wide_chtype for non-default include paths.

Fixes jeaye#151.
@ngg ngg mentioned this issue Apr 25, 2018
Merged
ngg added a commit to ngg/ncurses-rs that referenced this issue Apr 26, 2018
@ngg
Use pkg-config for all linked libraries.
daddcbb 
Fixes crashes when mixing wide and non-wide linker dependencies.

For example if both the "wide" and the "panel" features are enabled,
libncursesw.so and libpanel.so were linked which can not work together.

Another example is on Gentoo Linux where ncurses is split into
libncurses.so and libtinfo.so, previously libtinfo.so and libncursesw.so
were linked together if the "wide" feature was set.

Also fix the recognition of wide_chtype for non-default include paths.

Fixes jeaye#151.
@jeaye jeaye closed this as completed in #153 Jun 9, 2018
@quentinlesceller quentinlesceller mentioned this issue Apr 9, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pkg-config for all linked libraries. ngg/ncurses-rs
1 participant
@ngg