fix compatibility to wxPython>=4.1.1 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old code that made Videomass compatible with wxPython v4.0.7.
Many icons in
PNGformat have also been removed in favor of theSVGformat which seems to work well on new versions of wxPython.This is also useful for decreasing the size of the source code :-)
The FFmpeg warning regarding the
-vsyncargument has also been resolved:-vsync arg is deprecated, use fps_mode.So the minimum FFmpeg version required for Videomass is >=5.1.4 as the
-fps_modeargument will not work on FFmpeg <=4.4.4