Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you specify filename conforming pattern? #282

Open
johannesdedoper opened this issue Mar 21, 2024 · 9 comments
Open

Can you specify filename conforming pattern? #282

johannesdedoper opened this issue Mar 21, 2024 · 9 comments
Labels
question Further information is requested

Comments

@johannesdedoper
Copy link

johannesdedoper commented Mar 21, 2024

Hello Italy!

Hope your well!
Just noticed that sometimes files are not added to the queue.
Seems to be a filename issue.
Can you please give me the conforming_pattern?
eg. conforming_pattern='^[A-Za-z0-9_-.]+$' so I can make a small script checking this?
This way I can change the filenames that are not accepted.

Thanks in advance!
Cheers, J.

@jeanslack
Copy link
Owner

jeanslack commented Mar 23, 2024

Hello!

I'm fine thanks, I hope the same for you!

Yes, files are not added when they have the following incompatibilities:

In all these cases a window would be shown with the list of rejected files and the related error status. Can you confirm this please?

@johannesdedoper
Copy link
Author

Thnx for your reply.

In all these cases a window would be shown with the list of rejected files and the related error status. Can you confirm this please?

Yes, you are correct! Sorry, I did see the popup but did not scroll to the right to look at the complete notification.
It does say illegal characters are: ^ ` ~ " # % & * : < > ? / \ { | }
Anyway, I now know what will work and what will not.
BTW, the manage queue files feature sounds a very nice addition.

Cheers,
J.

@jeanslack jeanslack added the question Further information is requested label Mar 26, 2024
@jeanslack jeanslack pinned this issue Apr 19, 2024
@Oakchris1955
Copy link

  • illegal characters like: ^ ` ~ " # % & * : < > ? / \\ { | }

What is the purpose of filtering illegal file characters? Isn't that supposed to be the job of the filesystem?
I see that these are the characters that are forbidden in FAT filesystems, but on the other hand, most of them are allowed on other filesystems, like ext4.

@Oakchris1955
Copy link

  • illegal characters like: ^ ` ~ " # % & * : < > ? / \\ { | }

What is the purpose of filtering illegal file characters? Isn't that supposed to be the job of the filesystem? I see that these are the characters that are forbidden in FAT filesystems, but on the other hand, most of them are allowed on other filesystems, like ext4.

@jeanslack I'd appreciate an answer

@jeanslack
Copy link
Owner

Hi,
Sorry but I had definitely forgotten about this post.

Mainly filtering illegal characters was necessary to proceed smoothly using the file concatenation function on Videomass, since the special characters must be escaped using the FFmpeg syntax, which is quite cumbersome.
To realize this do some tests using exactly the FFmpeg concat function: https://ffmpeg.org/ffmpeg-formats.html#concat

Secondly, Videomass has the possibility to be used also as a renamer of the files you intend to process, therefore the filtering of the path names was necessary.

@Oakchris1955
Copy link

Mainly filtering illegal characters was necessary to proceed smoothly using the file concatenation function on Videomass, since the special characters must be escaped using the FFmpeg syntax, which is quite cumbersome.

So, is that only reason this restriction is in place? If so, I could probably open a PR so that Videomass properly filters those special characters.

@jeanslack
Copy link
Owner

Come to think of it, it's not the only reason: For me, it's a very useful feature that allows proper interoperability in exchanging files between file systems, and it doesn't disrupt my life by leaving this feature as it is.

@Oakchris1955
Copy link

Why not turn it into an optional feature that is enabled by default?

@jeanslack
Copy link
Owner

I had already thought about this possibility, but there are too many side-effects that even if improved would make the application too cumbersome and possibly fragile.
For the moment I would leave this thing alone, in the meantime I will try to think about it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants