Skip to content

ci: run perf jobs on bamboo #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 4 commits into from
Aug 1, 2026
Merged

ci: run perf jobs on bamboo #768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06759f0
ci: run perf jobs on bamboo
Aug 1, 2026
84eb28e
ci: use full bamboo capacity for perf
Aug 1, 2026
661e75b
ci: register bamboo actionlint label
Aug 1, 2026
0f527bc
ci: restrict bamboo perf prs to jdx
Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/perf-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ concurrency:
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: "0"
TAK_RUNNER: bamboo-v1-ubuntu24.04-x64-rust1.97.1

jobs:
measure:
Expand All @@ -35,7 +36,7 @@ jobs:
# between machine types by more than a real regression does, so a comparison
# across runner classes is not a comparison — tak refuses to make one, and
# the report would say "nothing was compared" instead of anything useful.
runs-on: ubuntu-latest
runs-on: bamboo-perf
Comment thread
cursor[bot] marked this conversation as resolved.
Resolved
timeout-minutes: 40
permissions:
# Read only. This job builds and runs code from the pull request, so it
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ concurrency:
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: "0"
TAK_RUNNER: bamboo-v1-ubuntu24.04-x64-rust1.97.1

jobs:
measure:
name: Measure
# Pinned to one runner class on purpose. Absolute instruction counts shift
# between machine types by more than a real regression does, so a series
# that wanders between runners is unreadable.
runs-on: ubuntu-latest
runs-on: bamboo-perf

@coderabbitai coderabbitai Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

configs="$(fd -a -t f 'actionlint\.ya?ml$' . || true)"
if [ -z "$configs" ]; then
  echo "No actionlint configuration found."
else
  while IFS= read -r config; do
    rg -n -C 2 'runner-label|bamboo-perf' "$config"
  done <<< "$configs"
fi

actionlint .github/workflows/perf-pr.yml .github/workflows/perf.yml

Repository: jdx/usage

Length of output: 2603

Configure actionlint for bamboo-perf.

Both performance workflows use the intended custom runner, but this repository has no actionlint configuration and actionlint rejects bamboo-perf as an unknown label. Add bamboo-perf to runner-label in actionlint.yaml, or update the actionlint invocation to ignore runner labels.

🧰 Tools
🪛 actionlint (1.7.12)

[error] 38-38: label "bamboo-perf" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2025-vs2026", "windows-2022", "windows-11-arm", "ubuntu-slim", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xlarge", "macos-latest-large", "macos-26-intel", "macos-26-xlarge", "macos-26-large", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xlarge", "macos-14-large", "macos-14", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows", "macos-14", "buildjet-32vcpu-ubuntu-2204-arm", "buildjet-16vcpu-ubuntu-2204-arm", "buildjet-8vcpu-ubuntu-2204-arm", "buildjet-4vcpu-ubuntu-2204-arm", "buildjet-2vcpu-ubuntu-2204-arm", "buildjet-32vcpu-ubuntu-2204", "buildjet-16vcpu-ubuntu-2204", "buildjet-8vcpu-ubuntu-2204", "buildjet-4vcpu-ubuntu-2204", "buildjet-2vcpu-ubuntu-2204". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

📍 Affects 2 files
  • .github/workflows/perf.yml#L38-L38 (this comment)
  • .github/workflows/perf-pr.yml#L39-L39
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/perf.yml at line 38, Add actionlint configuration for the
custom bamboo-perf runner by including bamboo-perf in runner-label within
actionlint.yaml. This covers the uses at .github/workflows/perf.yml:38-38 and
.github/workflows/perf-pr.yml:39-39; leave both workflow runner declarations
unchanged.

Source: Linters/SAST tools

timeout-minutes: 30
permissions:
contents: write # pushing refs/notes/tak is a write to this repository
Expand Down
Loading